Skip to content

Remove unnecessary async/await from svelte package tests #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2025
Merged

Remove unnecessary async/await from svelte package tests #4139

merged 2 commits into from
Nov 21, 2025
+348 −348

Conversation

Copy link
Contributor

Copilot AI commented Nov 21, 2025 •
edited
Loading

The render() function from vitest-browser-svelte is synchronous, but tests were incorrectly using async/await patterns.

Changes

  • Removed async keyword from test function declarations across all 23 component test files
  • Removed await keyword from render() calls

Before

it('renders', async () => {
  const { getByTestId } = await render(Test);
  expect(getByTestId('root')).toBeInTheDocument();
});

After

it('renders', () => {
  const { getByTestId } = render(Test);
  expect(getByTestId('root')).toBeInTheDocument();
});

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Nov 21, 2025
Draft
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 745e939

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
www.skeleton.dev Error Error Nov 21, 2025 3:02pm

Copilot AI changed the title [WIP] Remove all uses of '@/‘ paths alias from packages Remove unnecessary async/await from svelte package tests Nov 21, 2025
Copilot AI requested a review from Hugos68 November 21, 2025 15:03
Copilot finished work on behalf of Hugos68 November 21, 2025 15:03
@Hugos68 Hugos68 marked this pull request as ready for review November 21, 2025 15:06
@Hugos68 Hugos68 merged commit e5289cb into perf/monorepo Nov 21, 2025
0 of 2 checks passed
@Hugos68 Hugos68 deleted the copilot/sub-pr-4135 branch November 21, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hugos68 Hugos68 Awaiting requested review from Hugos68

Assignees

@Hugos68 Hugos68

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hugos68